This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domai

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain)
From: Rob Gardner <rob.gardner@xxxxxx>
Date: Wed, 05 Jul 2006 10:22:25 -0600
Cc: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 05 Jul 2006 09:22:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <ee63b7c284633bda16c01bc4591230f4@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060704.143731.74693697.kuwa@xxxxxxxxxxxxxx> <2a7a55c7de2d697c126797c1fb982850@xxxxxxxxxxxx> <20060704.164820.78765530.kuwa@xxxxxxxxxxxxxx> <ee63b7c284633bda16c01bc4591230f4@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (Windows/20060516)
Keir Fraser wrote:
Therefore, xenmon supports only up to 32 domains.

That's poor, since it in fact only really supports the first 31 domains created on a system (domain ids don't necessarily quickly get reused; and 32nd domid is used as sentinel to indicate idle). It shouldn't be hard to use a data structure more complicated than (presumably) a small array indexed by domid.

I know about this problem. I've got a fix for it I prepared some time ago but never got around to submitting. I'll integrate it with the latest source and get it sent out this week.


Xen-devel mailing list