This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domai

To: "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenmon: remove magic number "31" (the idle domain)
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 4 Jul 2006 08:06:57 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 04 Jul 2006 00:13:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060704.143731.74693697.kuwa@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060704.143731.74693697.kuwa@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 4 Jul 2006, at 06:37, KUWAMURA Shin'ya wrote:

This patch removes the magic number "31" for readability. The number
"31" means the idle domain ID.

In detail:
- display the idle domain ID with "Idle" instead of "31"
- write to the file "log-idle.log" instead of "log-dom31.log".

Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>

Where does the magic number '31' come from in the first place? That's not the number Xen uses. It could conflict with the domain id of a non-idle domain.

 -- Keir

Xen-devel mailing list