This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] credit scheduler issues in 64bit hypervisor

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] credit scheduler issues in 64bit hypervisor
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Wed, 5 Jul 2006 09:51:00 +0800
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Steven Hand <Steven.Hand@xxxxxxxxxxxx>, "Zheng, Jeff" <jeff.zheng@xxxxxxxxx>
Delivery-date: Tue, 04 Jul 2006 18:52:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcafmG/yIPIyVZifQs2cZhypKWpn+gADN9Dw
Thread-topic: [Xen-devel] credit scheduler issues in 64bit hypervisor
>>> OK, that's reasonable :-), I'll send out the patch.
>> This patch is to move vmcs and IO bitmap allocation into
>> vmx_initialize_guest_resources.
>> And some necessary code rearrangement.
>This patch messes with more stuff than it needs to.

OK, I splitted it. This patch only moves vmcs and IO bitmap allocation
into vmx_initialize_guest_resources.

> In particular, 
>every place we VMCLEAR/VMPTRLD we expect the operation to succeed -- 
>crashing on error is the most sensible thing to do. I don't see that 
>returning error to the caller is helpful, and in fact you have callers 
>who don't even check the error return. It keeps the interface to those 
>functions simpler to have them return void and for them to bug out 
>internally if they fail (as they currently do).

I really don't like crashing on such errors, but yes, this small changes
to VMCLEAR/VMPTRLD make no sense at this point.
For long term, we need follow IA32 SPEC to handle all the faliure VMX
instruction cases, basically we should crash the domain not the system,
and give some basic description.
I will send separate patches later, maybe after 3.0.3,

Attachment: con_vmcs.patch
Description: con_vmcs.patch

Xen-devel mailing list