WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] credit scheduler issues in 64bit hypervisor


On 4 Jul 2006, at 13:00, Li, Xin B wrote:

OK, that's reasonable :-), I'll send out the patch.

This patch is to move vmcs and IO bitmap allocation into
vmx_initialize_guest_resources.
And some necessary code rearrangement.

This patch messes with more stuff than it needs to. In particular, every place we VMCLEAR/VMPTRLD we expect the operation to succeed -- crashing on error is the most sensible thing to do. I don't see that returning error to the caller is helpful, and in fact you have callers who don't even check the error return. It keeps the interface to those functions simpler to have them return void and for them to bug out internally if they fail (as they currently do).

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel