WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [RFC][PATCH] synchronize console on BUG()

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC][PATCH] synchronize console on BUG()
From: Horms <horms@xxxxxxxxxxxx>
Date: Fri, 30 Jun 2006 11:35:53 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 30 Jun 2006 03:22:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <34A27D6A-0DEE-4757-A741-95289CEEBA54@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060629100103.6D54A3402E@xxxxxxxxxxxxxxxxx> <34A27D6A-0DEE-4757-A741-95289CEEBA54@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060403
On Thu, Jun 29, 2006 at 07:22:52AM -0400, Jimi Xenidis wrote:
> 
> On Jun 29, 2006, at 6:01 AM, Horms wrote:
> 
> >In article <E1Fvahf-0001xr-ME@xxxxxxxxxxxxxxxxxxxxx> you wrote:
> >>
> >>The following patch syncs (and unsync) the console while we are in  
> >>the
> >>BUG() macro.
> >>
> >>The separate externs (which I dislike) for these console calls are
> >>there because including <xen/console.h> breaks all sorts of files,  
> >>any
> >>suggestions on how to solve this is welcome.
> >
> >Is this breakage because <xen/console.h> doesn't #include all the
> >headers for the stuff it uses itself? If so could someone coment on
> >if that is intentional, or if it is something that (generally) wants
> >fixing.
> >
> 
> Methinks it includes to much, for some of the more finikier files.
> My suggestion is that we should have a minimal header that contains  
> prototypes for console_sync(), panic(), ASSERT, BUG, and whatever  
> else there is (perhaps remove the redundant ones if there are any).

That sounds reasonable, and may even speed up builds to some small
extent. However, regardless of the size of an include, it really
ought to be includable.

-- 
Horms                                           
H: http://www.vergenet.net/~horms/          W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>