This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [rfc] [patch] "frame number" size in hypercall ABI

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [rfc] [patch] "frame number" size in hypercall ABI
From: Joe Bonasera <joe.bonasera@xxxxxxx>
Date: Wed, 19 Apr 2006 08:32:14 -0700
Delivery-date: Wed, 19 Apr 2006 08:32:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1FWBAp-0008KG-7d@host-192-168-0-1-bcn-london>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FWBAp-0008KG-7d@host-192-168-0-1-bcn-london>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7) Gecko/20060307

Message: 3
Date: Wed, 19 Apr 2006 08:24:44 +0100
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [rfc] [patch] "frame number" size in
        hypercall ABI
To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Message-ID: <e3a01a5452fa05ddd61fde154e01d557@xxxxxxxxxxxx>
Content-Type: text/plain; charset=US-ASCII; format=flowed

On 18 Apr 2006, at 20:17, Hollis Blanchard wrote:


I also haven't converted Xen itself to use frameno_t except where
absolutely necessary. It isn't required to solve my immediate problem...

I think the patch looks okay in principle, except I notice a couple of 'framno_t' misspellings. I think 'pfn_t' would be more in keeping with the Xen naming scheme for arbitrary page frame numbers, but perhaps that name is a bit unnecessarily cryptic. What is the immediate problem you're needing to solve?

  -- Keir

Please don't use pfn_t, that's what Solaris already uses internally for
physical frame numbers. In the Xen code for Solaris, I introduced
mfn_t as the corresponding type for Xen's machine frame numbers.
frameno_t is fine, as I can just define mfn_t and frameno_t to be
the same, but conflicting pfn_t's would be problematic.


Xen-devel mailing list