WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] swiotlb

To: "Ky Srinivasan" <ksrinivasan@xxxxxxxxxx>
Subject: Re: [Xen-devel] swiotlb
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 14 Apr 2006 07:50:21 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 13 Apr 2006 23:53:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <443E7C63.E57C.0030.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <443E7C63.E57C.0030.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 13 Apr 2006, at 21:29, Ky Srinivasan wrote:

Given that the function __sync_single() can be called in an interrupt
context, why do we call a   potentially blocking function
(__copy_to_user) from within this function?

Good point. Would __copy_to_user_inatomic() be safe? It avoids might_sleep(). We know that the page fault itself (if any) will not block on I/O -- we only use __copy_to_user() to safely catch the fault and return.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>