WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Missing CDROM media

To: Ross Maxfield <rmaxfiel@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Missing CDROM media
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Mon, 10 Apr 2006 13:27:08 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 10 Apr 2006 11:27:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <443A2AA0.DD28.00D3.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <443A2AA0.DD28.00D3.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mail/News 1.5 (X11/20060309)
Ross Maxfield wrote:
If the 'cdrom=' option is specified in the definition file but media is not 
found in the CD drive then main() in vl.c exits and the guest appears to hang.  
This patch modifies vl.c slightly to check for the presents of media.  If the 
cdrom cannot be opened then the cd entry is removed from hd_filename[] and 
bs_table[] allowing the guest to continue initializing. If the guest requires 
the CD media then the guest should report, gracefully or otherwise, that it's 
missing.

This is desired behavior.

The cdrom is always attached to the guest. The cdrom option doesn't necessary attach a cdrom but rather attaches the media to the already existing cdrom. If you wish to later change the media, use the "change" option in the monitor.

Moving away from QEmu semantics is only going to make merging later more difficult. You could perhaps add a check to Xend that remove the cdrom option if media wasn't present. Then can expose the user interface we want without moving further away from QEmu.

Regards,

Anthony Liguori

I would like to see this patch applied to 3.0.2-testing as well.

Thanks,
Ross

------------------------------------------------------------------------

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>