This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] don't require ebtables in the host kernel

To: Avi Kivity <avi@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] don't require ebtables in the host kernel
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Wed, 22 Feb 2006 13:33:34 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 22 Feb 2006 13:47:30 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43FC26DB.7060906@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43FC26DB.7060906@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Feb 22, 2006 at 10:54:51AM +0200, Avi Kivity wrote:

> The network-bridge script fails when setting a few sysctls
> which are only available if ebtables is present in the host
> kernel. Fix by ignoring the return value of the sysctl command.
> Signed-off-by: Avi Kivity <avi@xxxxxxxxxxxx>
> Index: xen/tools/examples/network-bridge
> ===================================================================
> --- xen/tools/examples/network-bridge (revision 991)
> +++ xen/tools/examples/network-bridge (revision 992)
> @@ -158,9 +158,9 @@
>     # Don't create the bridge if it already exists.
>     if ! brctl show | grep -q ${bridge} ; then
> -     sysctl -w "net.bridge.bridge-nf-call-arptables=0"
> -     sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
> -     sysctl -w "net.bridge.bridge-nf-call-iptables=0"
> +     ! sysctl -w "net.bridge.bridge-nf-call-arptables=0"
> +     ! sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
> +     ! sysctl -w "net.bridge.bridge-nf-call-iptables=0"
>       brctl addbr ${bridge}
>       brctl stp ${bridge} off
>       brctl setfd ${bridge} 0

Where did this network-bridge script come from?  The stock Xen-3.0
network-bridge doesn't have these sysctl lines in the first place.

Furthermore, using ! doesn't ignore the return value -- it inverts it.  I'd be
surprised if this works in systems that _do_ have ebtables.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>