WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] don't require ebtables in the host kernel

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] don't require ebtables in the host kernel
From: Avi Kivity <avi@xxxxxxxxxxxx>
Date: Wed, 22 Feb 2006 10:54:51 +0200
Delivery-date: Wed, 22 Feb 2006 11:06:56 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
The network-bridge script fails when setting a few sysctls
which are only available if ebtables is present in the host
kernel. Fix by ignoring the return value of the sysctl command.

Signed-off-by: Avi Kivity <avi@xxxxxxxxxxxx>

Index: xen/tools/examples/network-bridge
===================================================================
--- xen/tools/examples/network-bridge   (revision 991)
+++ xen/tools/examples/network-bridge   (revision 992)
@@ -158,9 +158,9 @@

    # Don't create the bridge if it already exists.
    if ! brctl show | grep -q ${bridge} ; then
-       sysctl -w "net.bridge.bridge-nf-call-arptables=0"
-       sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
-       sysctl -w "net.bridge.bridge-nf-call-iptables=0"
+       ! sysctl -w "net.bridge.bridge-nf-call-arptables=0"
+       ! sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
+       ! sysctl -w "net.bridge.bridge-nf-call-iptables=0"
        brctl addbr ${bridge}
        brctl stp ${bridge} off
        brctl setfd ${bridge} 0


--
error compiling committee.c: too many arguments to function


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>