This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] linux TPM changes question

To: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] linux TPM changes question
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Wed, 15 Feb 2006 08:59:56 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 15 Feb 2006 14:12:15 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43F2F768.76F0.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

"Jan Beulich" <JBeulich@xxxxxxxxxx> wrote on 02/15/2006 03:42:00 AM:

> >>> Stefan Berger <stefanb@xxxxxxxxxx> 14.02.06 19:25:19 >>>
> >xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 02/14/2006 11:37:45 AM:
> >
> >> While there has been a new (conditionalized) call to
> >> del_singleshot_timer_sync() added, the old instance hasn't been
> >> deleted (other than the parallel atomic_set(&chip->data_pending,
> >> 0)). Is this intentional? If so, how is this supposed
> >> to work?
> >
> >This has most likely been introduced during the recent merging with newer
> >kernel trees.
> But this doesn't tell me if the current code is correct or has to be
> regarded broken (as I suspect)...

It can be regarded as broken. Thanks for finding this and I will post a patch later.

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>