WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] USB virt 2.6 split driver patch series

To: harry <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] USB virt 2.6 split driver patch series
From: NAHieu <nahieu@xxxxxxxxx>
Date: Tue, 22 Nov 2005 10:59:00 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 22 Nov 2005 01:58:55 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Fs89uCOvte/yteU6b8ikJL9UKKB8YQWovzaMgR0kThM6v/0dG5H1Idfi6wd4tpGIsPbPjRrGot+Lmr2ryB8ip3OiseCw31y/fS66/EKP5a+ubXPoUj2nAQIxtx9RY/qJEjq8umzt0u7aVzJyB7GQJ6wju0uA0praDR5KZeSUS44=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1132593451.31295.171.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1132579104.31295.110.camel@xxxxxxxxxxxxxxxxxxxxx> <20051121134940.GA25045@xxxxxxxxx> <1132581661.31295.134.camel@xxxxxxxxxxxxxxxxxxxxx> <5d7aca950511210641n23d79fduc2e462c3dcd07810@xxxxxxxxxxxxxx> <1132586050.31295.145.camel@xxxxxxxxxxxxxxxxxxxxx> <5d7aca950511210727i741148efl71f025577680d994@xxxxxxxxxxxxxx> <1132587554.31295.154.camel@xxxxxxxxxxxxxxxxxxxxx> <5d7aca950511210902j5002bbfdxe52b1a32517d6c8b@xxxxxxxxxxxxxx> <1132593451.31295.171.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I had a look at xenidc code, and found some code like this:

--
static void xenidc_endpoint_destroy_1(xenidc_callback * callback)
{
        trace();

        {
                xenidc_endpoint_callback *endpoint_callback =
                    container_of(callback, xenidc_endpoint_callback, callback);

                endpoint_callback->destroyed = 1;

                xenidc_work_wake_up();
        }
}
--

Why name it *destroy_1? it is a common practice to name a local
function with _ or __ as prefix. So for example
xenidc_endpoint_destroy_1() should be named
_xenidc_endpoint_destroy_1() or __xenidc_endpoint_destroy_1()

Hieu

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>