WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][VT] Fix vnc configure problem for vmx guest

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][VT] Fix vnc configure problem for vmx guest
From: Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>
Date: Mon, 26 Sep 2005 09:51:17 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 26 Sep 2005 01:51:58 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050923160027.GL2439@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <3ACA40606221794F80A5670F0AF15F840999E329@pdsmsx403> <20050923160027.GL2439@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
Ewan Mellor wrote:
On Fri, Sep 23, 2005 at 11:12:26PM +0800, Ling, Xiaofeng wrote:


see attach mail. That is why configVNC is seperated.
I know this fix is not seems so ideal, I'd like to know if you have good idea for the problem.


Thanks for that.  I've had a look, and I don't see any reason for ImageHandler
to be created before the domain itself, so I've moved the ImageHandler.create
call so that it is after the xc.domain_create call.  This means that you have
the domid available inside configVNC, as necessary.

The change will be pushed to the public server in the next few minutes.  Let
me know how you get on.

Yes, moving ImageGandler.create after domain create resolves the problem. but I guess the original purpose of putting ImageHandler.create after domain creating maybe if ImageHanler.ceate fails(some configuration wrong), there'll be no useless domain struct exists.
So I seperates the configVNC and put it after the domain creating.
Maybe better way is have a pre-config and post-config?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel