WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] xen Makefile being nasty with EXTRAVERSION

To: Nuutti Kotivuori <naked@xxxxxx>
Subject: Re: [Xen-devel] xen Makefile being nasty with EXTRAVERSION
From: Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>
Date: Sat, 23 Oct 2004 12:07:47 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxxx, Ian.Pratt@xxxxxxxxxxxx
Delivery-date: Sat, 23 Oct 2004 13:34:21 +0100
Envelope-to: steven.hand@xxxxxxxxxxxx
In-reply-to: Your message of "Sat, 23 Oct 2004 02:16:11 +0300." <87wtxicpj8.fsf@xxxxxxxxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
> There is a snippet in the xen Makefile like this:
> 
>   EXTRAEXTRAVERSION=$(subst $(findstring $(EXTRAVERSION),$(shell basename 
> $(TOPDIR))),,$(EXTRAVERSION))
>   override EXTRAVERSION:=$(subst 
> linux-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL),,$(shell basename 
> $(TOPDIR)))$(EXTRAEXTRAVERSION)
> 
> Now, this probably works fine if the basename of the kernel directory
> is something common. And it is probably perfectly okay to do that in
> the 'make world' Xen builds. But if Xen is treated like 'just another
> kernel patch' or if distributions wish to provide Xen kernels, this is
> a major pain in the ass.

Yeah, I agree, but its very useful.

I propose the following replacement: We test to see whether
there's a .extraversion file, and if so override EXTRAVERSION
with the contents of the file. This should be compatible with
distros and still be convenient for us.

There's already quite a bit of 'diversity' with the way different
architectures deal with handling default configs etc, so I think
we'll get away with this.

I'll make the change unless anyone shouts soon.

Ian


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel