This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-API] [PATCH] imported patch removing-warnings

To: Jonathan Knowles <Jonathan.Knowles@xxxxxxxxxxxxx>, Rok Strnisa <rok.strnisa@xxxxxxxxxx>
Subject: RE: [Xen-API] [PATCH] imported patch removing-warnings
From: Dave Scott <Dave.Scott@xxxxxxxxxxxxx>
Date: Wed, 10 Nov 2010 15:30:25 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc: Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>, "xen-api@xxxxxxxxxxxxxxxxxxx" <xen-api@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 Nov 2010 07:34:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CDA8E27.3030604@xxxxxxxxxxxxx>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <403764544b97988f2e3d.1289323667@rok-desktop> <4CDA61E7.5060509@xxxxxxxxxxxxx> <B462D1536FED1140871BC97AB218A6598EFA3A1CC7@xxxxxxxxxxxxxxxxxxxxxxxxx> <4CDA8827.1060607@xxxxxxxxxxxxx> <B462D1536FED1140871BC97AB218A6598EFA3A1CCA@xxxxxxxxxxxxxxxxxxxxxxxxx>, <4CDA8E27.3030604@xxxxxxxxxxxxx>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuA0bxBDvVDNmSeSqmpm455u1aM5wAGnXrG
Thread-topic: [Xen-API] [PATCH] imported patch removing-warnings
(I apologies if my email is badly formatted... silly web mail client in use)

My quick comments are:
1. a lot of warnings will be attributed to the "xen hg user" (have a look at 
"hg export 0")
2. as a special case, it might be good to view fixing warnings as a task for 
newbies to help familiarise them with the codebase. I would agree with the 
notion that henceforth, new warnings should be treated as bugs and the creator 
should tidy them up.


From: Jonathan Knowles
Sent: 10 November 2010 12:20
To: Rok Strnisa
Cc: Vincent Hanquez; xen-api@xxxxxxxxxxxxxxxxxxx; Dave Scott
Subject: Re: [Xen-API] [PATCH] imported patch removing-warnings

On 10/11/10 12:08, Rok Strnisa wrote:
> Because this will take some effort, I've decided to not do it all
> myself, but rather use the source control to identify who is
> responsible for each warning, and delegate it to them --- originally
> an idea by Jonathan Knowles.

Yes -- it ought to be possible to distribute this work:

1. grep the results of a successful build for warnings
2. convert the warnings into a warning list w, where w = [(file, line)]
3. use hg annot to identify the person that last touched each line
4. partition list w into a per-user list of warnings: [(user, [(file,
5. create a bug report for each user, along with their list of warnings.



xen-api mailing list