This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-API] [PATCH] imported patch removing-warnings

To: Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>
Subject: RE: [Xen-API] [PATCH] imported patch removing-warnings
From: Rok Strnisa <rok.strnisa@xxxxxxxxxx>
Date: Wed, 10 Nov 2010 14:45:04 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-api@xxxxxxxxxxxxxxxxxxx" <xen-api@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 Nov 2010 06:45:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CDA94FA.1020605@xxxxxxxxxxxxx>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <403764544b97988f2e3d.1289323667@rok-desktop> <4CDA61E7.5060509@xxxxxxxxxxxxx> <B462D1536FED1140871BC97AB218A6598EFA3A1CC7@xxxxxxxxxxxxxxxxxxxxxxxxx> <4CDA8827.1060607@xxxxxxxxxxxxx> <B462D1536FED1140871BC97AB218A6598EFA3A1CCA@xxxxxxxxxxxxxxxxxxxxxxxxx> <4CDA94FA.1020605@xxxxxxxxxxxxx>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuA1csGzBHJnO3USzyRAltWv1qWOgADvJIg
Thread-topic: [Xen-API] [PATCH] imported patch removing-warnings
> > My patch did not introduce any future hard-to-find bugs, since any
> > change of the type you describe above would still have been silently
> > ignored by the compiler even without the change.
> yes, the partial application would not have triggered either when it's
> linked to a name, however you do remove potential audit site (warning
> lines), since "unused variable" warnings has been silenced.

As I mentioned in my previous email, a commented-out variable name may well be 
more visible and targeted than a warning hidden in a sea of them.

If you would like to discuss this further, I suggest taking it offline.


xen-api mailing list