xen-ia64-devel

[Top] [All Lists]

RE: [Xen-ia64-devel] VHPI restore mechanism at save/restore

from [Zhang, Xiantao]

[Permanent Link][Original]

To:	"Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject:	RE: [Xen-ia64-devel] VHPI restore mechanism at save/restore
From:	"Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date:	Fri, 1 Feb 2008 21:23:10 +0800
Cc:	xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 01 Feb 2008 05:23:31 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20080201122823.GL26750%yamahata@xxxxxxxxxxxxx>
List-help:	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id:	Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post:	<mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<51CFAB8CB6883745AE7B93B3E084EBE201702846@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080201075806.GJ26750%yamahata@xxxxxxxxxxxxx> <42DFA526FC41B1429CE7279EF83C6BDCD32352@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080201122823.GL26750%yamahata@xxxxxxxxxxxxx>
Sender:	xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Achkzg9sJRVvEuvjT7e8GNrt7OZm+AABm6gg
Thread-topic:	[Xen-ia64-devel] VHPI restore mechanism at save/restore

Isaku Yamahata wrote:
> On Fri, Feb 01, 2008 at 06:11:13PM +0800, Zhang, Xiantao wrote:
>> Hi,Isaku
>> I have a question about the mechanism for save/restore vhpi.  In
>> current save/restore code, vhpi register is only saved and restored
>> by vlsapic_save/load, but it maybe not enough for ensuring
>> correctness.  IMO, we need to call PAL_VPS_SET_PENDING_INTERRUPT
>> again to set it， and make cpu aware of its value.  Do I miss
>> something ? :)     
> 
> Please notice the line in vlsapic_load()
>     v->arch.irq_new_pending = 1; /* to force checking irq */

Why need to set the force check here?   Any special reasons or scenarios which 
need it ? :)

> and see leave_hypervisor_tail() which is always called before
> entering VTi guest.
> leave_hypervisor_tail() eventually calls
> PAL_VPS_SET_PENDING_INTERRUPT. At least this is my intention. Do you
> find any path where it isn't called? 

The force check may workaround the lost VHPI, so it should work. 


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] VHPI restore mechanism at save/restore, Zhang, Xiantao Re: [Xen-ia64-devel] VHPI restore mechanism at save/restore, Isaku Yamahata RE: [Xen-ia64-devel] VHPI restore mechanism at save/restore, Zhang, Xiantao <=

Previous by Date:	[Xen-devel] Re: [Xen-ia64-devel] [IA64] Weekly benchmark results [ww04], Isaku Yamahata
Next by Date:	RE: [Xen-ia64-devel] paravirt_ops and its alternatives, Dong, Eddie
Previous by Thread:	Re: [Xen-ia64-devel] VHPI restore mechanism at save/restore, Isaku Yamahata
Next by Thread:	[Xen-ia64-devel] [IA64] Weekly benchmark results [ww04], KUWAMURA Shin'ya
Indexes:	[Date] [Thread] [Top] [All Lists]