Re: [Xen-ia64-devel] VHPI restore mechanism at save/restore

On Fri, Feb 01, 2008 at 06:11:13PM +0800, Zhang, Xiantao wrote:
> Hi,Isaku
> I have a question about the mechanism for save/restore vhpi.  In current 
> save/restore code, vhpi register is only saved and restored by 
> vlsapic_save/load, but it maybe not enough for ensuring correctness.  IMO, we 
> need to call PAL_VPS_SET_PENDING_INTERRUPT again to set it， and make cpu 
> aware of its value.  Do I miss something ? :)

Please notice the line in vlsapic_load()
    v->arch.irq_new_pending = 1; /* to force checking irq */

and see leave_hypervisor_tail() which is always called before
entering VTi guest.
leave_hypervisor_tail() eventually calls PAL_VPS_SET_PENDING_INTERRUPT.
At least this is my intention. Do you find any path where it isn't called?

thanks.
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] VHPI restore mechanism at save/restore, Zhang, Xiantao Re: [Xen-ia64-devel] VHPI restore mechanism at save/restore, Isaku Yamahata <= RE: [Xen-ia64-devel] VHPI restore mechanism at save/restore, Zhang, Xiantao

Previous by Date:

Re: [Xen-ia64-devel] Question about migration, Isaku Yamahata

Next by Date:

[Xen-devel] Re: [Xen-ia64-devel] [IA64] Weekly benchmark results [ww04], Isaku Yamahata

Previous by Thread:

[Xen-ia64-devel] VHPI restore mechanism at save/restore, Zhang, Xiantao

Next by Thread:

RE: [Xen-ia64-devel] VHPI restore mechanism at save/restore, Zhang, Xiantao

Indexes:

[Date] [Thread] [Top] [All Lists]