Re: [Xen-devel] [PATCH] libxl: Include a version of bsd's queue.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-10-26 at 09:44 +0100, Roger Pau Monné wrote:
> 2011/10/25 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:

[snip a thousand line of unnecessary quotes]

> > diff --git a/tools/libxl/bsd-sys-queue-h-seddery 
> > b/tools/libxl/bsd-sys-queue-h-seddery
> > new file mode 100755
> > index 0000000..0bab8e0
> > --- /dev/null
> > +++ b/tools/libxl/bsd-sys-queue-h-seddery
> > @@ -0,0 +1,67 @@
> > +#!/usr/bin/perl -p
> 
> This should be something like:
> 
> #!/usr/bin/env perl
> 
> For this script to work on BSD systems, which usually have perl in
> /usr/pkg/bin/perl or /usr/local/bin/perl

It took me several minutes to find this two line comment on one line of
code in the ~2000 lines you quoted. Please (everyone) think of the
reader and trim your quotes.

(not specifically just at you Roger, this sort of thing happens too
often on this list)

[snip almost a thousand more lines]

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel