Re: [Xen-devel] [PATCH 10 of 15] xenpaging: compare both token and path when checking for @releaseDomain event

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [Xen-devel] [PATCH 10 of 15] xenpaging: compare both 
token and path when checking for @releaseDomain event"):
> I was under the impression there could be identical tokens for different
> paths,

Yes, but you control the token.  The token you get back in your watch
event is whatever you gave to xs_watch.

> and that the actual value of the watched path is part of
> XS_WATCH_TOKEN.

"XS_WATCH_TOKEN" is just an array index into the return value of
xs_read_watch.  It has the value 1 which means that
  ret = xs_read_watch(...)
returns the token in ret[1].  The path comes back in ret[0].

(The use of "xs_watch_type" as the name for this enum is unfortunate.)

> But since the token seems to be unique (docs/misc/xenstore.txt has no
> further description of 'token'), only the DPRINTF part of my patch
> should be kept.

The token is whatever you specified when you set up the watch.  I
haven't checked in xenpagingd what that value is in this case.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel