Re: [Xen-devel] [PATCH 10 of 15] xenpaging: compare both token and path when checking for @releaseDomain event

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Oct 25, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 10 of 15] xenpaging: compare both 
> token and path when checking for @releaseDomain event"):
> > xenpaging: compare both token and path when checking for @releaseDomain 
> > event
> > 
> > Subsequent patches will use xenstored to store the numbers of pages
> > xenpaging is suppose to page-out. A domain_id value could be
> > misinterpreted as number of pages. Compare both path and token to
> > recognize the @releaseDomain event.
> 
> I'm not sure I understand.  What are you currently using as the
> token ?  The token as well as the path should be sufficient to be able
> to tell what the event is, so this patch makes me suspicious ...

I was under the impression there could be identical tokens for different
paths, and that the actual value of the watched path is part of
XS_WATCH_TOKEN.  So this patch tries to make the detection of the
@releaseDomain event more robust.

But since the token seems to be unique (docs/misc/xenstore.txt has no
further description of 'token'), only the DPRINTF part of my patch
should be kept.

Please drop this change, I will add the DPRINTF in a separate patch.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel