This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 1 of 6] pygrub should check all GPT partitions

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1 of 6] pygrub should check all GPT partitions
From: M A Young <m.a.young@xxxxxxxxxxxx>
Date: Thu, 20 Oct 2011 09:34:48 +0100 (BST)
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 20 Oct 2011 01:36:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1319099119.3385.113.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1110200002250.15667@xxxxxxxxxxxxxxxx> <1319099119.3385.113.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)
On Thu, 20 Oct 2011, Ian Campbell wrote:

On Thu, 2011-10-20 at 00:03 +0100, M A Young wrote:
On Fedora 16 the first GPT partition is a boot partition for grub2
the grub2 configuration in the second partition.
Check all GPT partitions for grub configuration, not just the first.
Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>

--- a/tools/pygrub/src/pygrub   2011-10-16 20:58:02.000000000 +0100
+++ b/tools/pygrub/src/pygrub   2011-10-16 20:59:52.000000000 +0100
@@ -78,9 +78,17 @@
 def get_fs_offset_gpt(file):
     fd = os.open(file, os.O_RDONLY)
     # assume the first partition is an EFI system partition.

Is this comment now inaccurate?

Yes. I haven't tested the case where the first partition is an EFI system partition though I think my changes would be harmless.

        Michael Young

Xen-devel mailing list