| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries
On Tue, 2011-10-18 at 11:53 +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools/build: append user
> includes and libraries at the end of the compile flags"):
> > On second through, I think it would be appropriate to rename EXTRA_LIB
> > and EXTRA_INCLUDES to PREPEND_LIB and PREPEND_INCLUDES, and create two
> > new variables called APPEND_INCLUDES and APPEND_LIB that perform the
> > same task as USER_CFLAGS and USER_LDFLAGS (append at the end). I think
> > it would be much more clearer using descriptive variable names, since
> > USER_ and EXTRA_ can lead to confusion.
>
> That would be neater, but I don't think it's helpful to people for us
> to be renaming our build variables.
>
> Anyone who is repackaging Xen (distros, XCP, ...) would prefer the
> variables to say the same even if the names aren't ideal.
As long as we keep the old names as well is there harm in adding new,
more descriptive names as well? i.e.
$(PREPEND_LIB) $(EXTRA_LIB) ... $(APPEND_LIB)
?
or even PREPEND_LIB ?= $(EXTRA_LIB) and "$(PREPEND_LIB) ...
$(APPEND_LIB)". That way things don't break today and when a packager
finds they actually need the distinction they can switch.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home