WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Mon, 17 Oct 2011 16:43:49 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 17 Oct 2011 07:44:25 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=SJse62mfByfeGNdn/SGJh3BgospjrH+FA2YLBXTKJW0=; b=aDE9rFrs0X/G7wwzn83fWPuKbL6g77d7JHmtds1UTde06o+NzC19u2sUD7GxKszUo6 5FzmmrZHWtwTHcA7ECKQF4qD81tCaQD4saooxBgXZpE47h9QXg/HRB96ttOuyaCtvF+6 kgxcGJ2ZbtM6pdvOmUZpETiGphNraR7KY2RGw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20124.16018.111545.330437@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <ae251a2f9490dfa98553.1318594610@loki> <20124.15541.672787.681791@xxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK7NH6AZ8urX5yAmV3L_zt06NDJa3kgZUgZ8c3hFQG49Pg@xxxxxxxxxxxxxx> <20124.16018.111545.330437@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
2011/10/17 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools/build: append user 
> includes and libraries at the end of the compile flags"):
>> In .config extra libraries and includes should be defined with
>> EXTRA_INCLUDES and EXTRA_LIB (the same way it is now), USER_LDFLAGS
>> and USER_CFLAGS is an internal make variable, and should not be set
>> directly by the user. Notice the lines:
>>
>> +USER_LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i))
>> +USER_CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))
>>
>> EXTRA_LIB and EXTRA_INCLUDES is added to USER_LDFLAGS and USER_CFLAGS
>> instead of LDFLAGS and CFLAGS.
>
> Oh, sorry, I didn't spot that.
>
> In that case I think it's not correct because that's changing the
> semantics of the existing EXTRA_* variables.  In particular, some
> people might currently set EXTRA_* expecting them to come first.
>
> We should have a new variable for the new semantics.  I confess I
> didn't read your patch closely enough to spot that you hadn't done
> that...

Ok, in that case I think we should define a new variable called
USER_CFLAGS and USER_LDFLAGS if everyone is comfortable with that. I
will send a new version with this changes.

>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel