WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial d

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial device is configured
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Thu, 13 Oct 2011 10:47:10 +0100
Cc: Anthony.Perard@xxxxxxxxxx, Ian.Jackson@xxxxxxxxxx
Delivery-date: Thu, 13 Oct 2011 02:48:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.6.4
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1318499067 -3600
# Node ID 6ca28d551fd5f3d7d7849b6b95d3beda5b9cd10e
# Parent  82b2eeea91d059dd79cf7621d487a0cf7d29933e
libxl: remove QMP warning when no pty style serial device is configured

If the serial device is not "pty" then there is nothing to do but this is not
an error. Removes a spurious warning if e.g. serial="file:/tmp/serial.log" is 
used:

libxl: error: libxl_qmp.c:137:register_serials_chardev_callback: Failed to 
store serial port information in xenstore: No such file or directory


Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 82b2eeea91d0 -r 6ca28d551fd5 tools/libxl/libxl_qmp.c
--- a/tools/libxl/libxl_qmp.c   Thu Oct 13 10:44:25 2011 +0100
+++ b/tools/libxl/libxl_qmp.c   Thu Oct 13 10:44:27 2011 +0100
@@ -87,7 +87,7 @@ static int store_serial_port_info(libxl_
     int ret = 0;
 
     if (!(chardev && strncmp("pty:", chardev, 4) == 0)) {
-        return -1;
+        return 0;
     }
 
     path = libxl__xs_get_dompath(&gc, qmp->domid);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>