WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial d

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial device is configured
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Tue, 4 Oct 2011 14:45:53 +0100
Cc: Anthony.Perard@xxxxxxxxxx
Delivery-date: Tue, 04 Oct 2011 06:46:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.6.4
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1317735934 -3600
# Node ID a0b8388fc4c82e345377679f4bffe7ab5d9eb55d
# Parent  c344d6d30b0f3796ebff069d6ecdde481c9e6a32
libxl: remove QMP warning when no pty style serial device is configured

If the serial device is not "pty" then there is nothing to do but this is not
an error. Removes a spurious warning if e.g. serial="file:/tmp/serial.log" is 
used:

libxl: error: libxl_qmp.c:137:register_serials_chardev_callback: Failed to 
store serial port information in xenstore: No such file or directory


Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r c344d6d30b0f -r a0b8388fc4c8 tools/libxl/libxl_qmp.c
--- a/tools/libxl/libxl_qmp.c   Tue Oct 04 14:43:56 2011 +0100
+++ b/tools/libxl/libxl_qmp.c   Tue Oct 04 14:45:34 2011 +0100
@@ -87,7 +87,7 @@ static int store_serial_port_info(libxl_
     int ret = 0;
 
     if (!(chardev && strncmp("pty:", chardev, 4) == 0)) {
-        return -1;
+        return 0;
     }
 
     path = libxl__xs_get_dompath(&gc, qmp->domid);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>