 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
| To: | Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification |
| From: | Keir Fraser <keir.xen@xxxxxxxxx> |
| Date: | Fri, 07 Oct 2011 09:00:32 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Fri, 07 Oct 2011 01:04:46 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=iuP6HlbC+xkOjWuD3AkMYH5pT18ICWCc4V19bMhmxjU=; b=jENT+g1KXCRiONAS9+3r9rFr0cAG3nIUlfBfH60GBIcoWiyYv8Dypsr8tLxBzldX8S hFUXWXNl7ql+oNRsSEEgG0XY0KJlXRqJtaXw+/lqRZNeb6WqjrdzxBPQJma57Ft2VI10 2kMqaYcmzA5iHczoLXzhdwWUB2XuB0VjLdOik= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1317973890.21903.280.camel@xxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcyExy+rzoROXVXAIkaCq3nuFHJ3jg== |
| Thread-topic: | [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification |
| User-agent: | Microsoft-Entourage/12.30.0.110427 |
On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote: > On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote: >> XEN_ROOT must be set to an absolute path to avoid out of the tree references > > How about: > > # HG changeset patch > # User Ian Campbell <ian.campbell@xxxxxxxxxx> > # Date 1317973741 -3600 > # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16 > # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02 > tools: error out on non-absolute $(XEN_ROOT) > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Why not put this in root Config.mk? The restriction applies outside tools/ as well. -- Keir > diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk > --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100 > +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100 > @@ -3,6 +3,10 @@ > # `all' is the default target > all: > > +ifeq ($(filter /%,$(XEN_ROOT)),) > +$(error XEN_ROOT must be absolute) > +endif > + > include $(XEN_ROOT)/Config.mk > > export _INSTALL := $(INSTALL) > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] HYBRID: set_page_prot() (make pte readonly), Ian Campbell |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification, Ian Campbell |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification, Juergen Gross |
| Next by Thread: | Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification, Ian Campbell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
