WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 7 Oct 2011 08:51:29 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 07 Oct 2011 00:52:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <67f2c8de11ecb6d05e22.1317962572@nehalem1>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <67f2c8de11ecb6d05e22.1317962572@nehalem1>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
> XEN_ROOT must be set to an absolute path to avoid out of the tree references

How about:

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1317973741 -3600
# Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
# Parent  f17f0df2a2ede01a8c35dc4768a532a4438b1c02
tools: error out on non-absolute $(XEN_ROOT)

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
--- a/tools/Rules.mk    Wed Oct 05 10:43:41 2011 +0100
+++ b/tools/Rules.mk    Fri Oct 07 08:49:01 2011 +0100
@@ -3,6 +3,10 @@
 # `all' is the default target
 all:
 
+ifeq ($(filter /%,$(XEN_ROOT)),)
+$(error XEN_ROOT must be absolute)
+endif
+
 include $(XEN_ROOT)/Config.mk
 
 export _INSTALL := $(INSTALL)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel