Re: [Xen-devel] [PATCH 00 of 24] xenpaging fixes for xen-unstable

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-10-03 at 16:54 +0100, Olaf Hering wrote:
> The following series adds support for xenpaging to libxl and the xl command.
> A few code cleanup changes are also part of this series.
> 
> The logic of xenpaging was reversed.
> It does now monitor the guests tot_pages value and work toward that number by
> either paging out more pages, or write pages back into the guest.
> 
> Three new configuration file options specific for xenpaging were added:
> totmem=<int>
> xenpaging_file=<string>
> xenpaging_extra=[ 'string', 'string' ]
> 
> A new xl command 'mem-tot_pages' instructs xenpaging to adjust its pagefile
> size, and it instructs the xl monitor process to actually start xenpaging if
> totmem= was not specified in the config file.

In general xl commands do not contain "_" but rather use "-". We also
sometimes use a "-set" suffix too.

totmem is unfortunately not all that descriptive to an end user of what
it does (which I think is a general problem we have with the memory
related options).

Currently the xl config file options are:
        memory = actual start of day RAM
        maxmem = max ram guest could balloon to (?)

How does POD fit in? Is it just maxmem-memory for HVM domains? (not
really relevant for this discussion, more for completeness).

The associated command line options are:
        mem-set (runtime equivalent of memory?)
        mem-max (runtime equivalent of maxmem?)

Hmm, I was hoping that enumerating the existing options would make the
name and semantics of the paging option magically pop into my head, I
was wrong :-(

BTW tools/libxl/libxl_memory.txt should be patched by this series too,
once we figure out what to call things.

The phrase "actual memory" is used in that document -- perhaps that is
suitable terminology for totmem?

Ian.

> 
> Please review and apply.
> 
> Olaf
> 
> 
>  Config.mk                        |    2 
>  config/StdGNU.mk                 |    2 
>  tools/libxc/xc_bitops.h          |    6 
>  tools/libxl/libxl.c              |  121 +++++++++
>  tools/libxl/libxl.h              |    5 
>  tools/libxl/libxl_create.c       |  146 +++++++++++
>  tools/libxl/libxl_device.c       |   84 ------
>  tools/libxl/libxl_dm.c           |   65 +----
>  tools/libxl/libxl_dom.c          |    8 
>  tools/libxl/libxl_exec.c         |  142 +++++++++++
>  tools/libxl/libxl_internal.h     |   33 ++
>  tools/libxl/libxl_paths.c        |    5 
>  tools/libxl/libxl_types.idl      |    4 
>  tools/libxl/xl.h                 |    1 
>  tools/libxl/xl_cmdimpl.c         |   71 +++++
>  tools/libxl/xl_cmdtable.c        |    5 
>  tools/xenpaging/Makefile         |    6 
>  tools/xenpaging/file_ops.c       |    6 
>  tools/xenpaging/policy_default.c |   23 +
>  tools/xenpaging/xenpaging.c      |  479 
> ++++++++++++++++++++++++++++-----------
>  tools/xenpaging/xenpaging.h      |    8 
>  21 files changed, 934 insertions(+), 288 deletions(-)
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel