Re: [Xen-devel] [PATCH 14 of 24] libxl: add pid path to libxl__spawner_starting

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Oct 04, Ian Campbell wrote:

> On Mon, 2011-10-03 at 16:54 +0100, Olaf Hering wrote:

> > +++ b/tools/libxl/libxl_internal.h
> > @@ -250,6 +250,7 @@ typedef struct {
> >  
> >  typedef struct {
> >      char *dom_path; /* from libxl_malloc, only for 
> > libxl_spawner_record_pid */
> > +    char *pid_path; /* from libxl_malloc, only for 
> > libxl_spawner_record_pid */
> 
> Either this new comment is true and you need a strdup() up above where
> you set it and a free() somewhere else (or use libxl__strdup()) or it is
> false and it should be removed and pid_path should be const char *.
> 
> I think the second option is sufficient for the current and new user you
> are about to add?

I duplicated the dom_path line without paying attention to the comment.
A const char *pid_path; is sufficient.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel