WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize i

To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Wed, 22 Jun 2011 19:00:06 +0100
Cc: QEMU-devel <qemu-devel@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 22 Jun 2011 10:57:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTi=BHQxbebFGAW+0L739q6Y4ivWLLQ@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1308758311-32692-1-git-send-email-anthony.perard@xxxxxxxxxx> <alpine.DEB.2.00.1106221842110.12963@kaball-desktop> <BANLkTi=BHQxbebFGAW+0L739q6Y4ivWLLQ@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 22 Jun 2011, Anthony PERARD wrote:
> On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > On Wed, 22 Jun 2011, anthony.perard@xxxxxxxxxx wrote:
> >> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >>
> >> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >> ---
> >>  hw/piix_pci.c |    3 +++
> >>  1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> >> index 26ce904..d08b31a 100644
> >> --- a/hw/piix_pci.c
> >> +++ b/hw/piix_pci.c
> >> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> >>          .no_hotplug   = 1,
> >>          .init         = piix3_initfn,
> >>          .config_write = piix3_write_config_xen,
> >> +        .vendor_id    = PCI_VENDOR_ID_INTEL,
> >> +        .device_id    = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 
> >> PCI-to-ISA bridge (Step A1)
> >> +        .class_id     = PCI_CLASS_BRIDGE_ISA,
> >>      },{
> >>          /* end of list */
> >>      }
> >
> > shouldn't piix3_initfn take care of setting vendor_id, device_id and
> > class_id, as in the normal PIIX3 case?
> 
> Not anymore. These ids have been removed from piix3_initfn and added
> to the PCIDeviceInfo of PIIX3 in the last update.

I see. Good catch.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel