WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize i

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Wed, 22 Jun 2011 18:48:30 +0100
Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>
Delivery-date: Wed, 22 Jun 2011 10:49:30 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=nRD4gcQmhbpTrR4f2lmT5bqJHpcBaxUgUBlKAlnzBL4=; b=r4sKw/03ETK+3U0q9v3Drk6JFyljQvPUgkIX418UiAMYhF2qr2DvVhESLs6W/k1dst /k+b9MrXS48vTteFe+2NrZV+532VJ/ZPCKAeD2t74wFPXXIA91ndhHF/bgZraqtfpghQ PqadDJspe1v1PfP/b3rlbag1UWpnY2hQ3HoBw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=pAQjjyAKbRmTQjxjHdCtdoQHjcfM7g54ivi6ylsgBmVajNRhVaDK9bG5jDYm8k4DV9 13/UrwqwycUr+b9nHUzNqAaQwesaD7wwaI4+aGOME4vTSm0Y+iXRww6MIsj+CNvYO+oc ENCxJ/jeO5LA1LApyTmFqYMI1vRhUY3GpasO0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1106221842110.12963@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1308758311-32692-1-git-send-email-anthony.perard@xxxxxxxxxx> <alpine.DEB.2.00.1106221842110.12963@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Wed, 22 Jun 2011, anthony.perard@xxxxxxxxxx wrote:
>> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> ---
>>  hw/piix_pci.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
>> index 26ce904..d08b31a 100644
>> --- a/hw/piix_pci.c
>> +++ b/hw/piix_pci.c
>> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
>>          .no_hotplug   = 1,
>>          .init         = piix3_initfn,
>>          .config_write = piix3_write_config_xen,
>> +        .vendor_id    = PCI_VENDOR_ID_INTEL,
>> +        .device_id    = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 
>> PCI-to-ISA bridge (Step A1)
>> +        .class_id     = PCI_CLASS_BRIDGE_ISA,
>>      },{
>>          /* end of list */
>>      }
>
> shouldn't piix3_initfn take care of setting vendor_id, device_id and
> class_id, as in the normal PIIX3 case?

Not anymore. These ids have been removed from piix3_initfn and added
to the PCIDeviceInfo of PIIX3 in the last update.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel