WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcend

To: Nikanth Karthikesan <nikanth@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcendent Memory only if Cleancache is enabled
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Tue, 14 Jun 2011 09:09:23 -0700 (PDT)
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Tue, 14 Jun 2011 09:10:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1308040987.28682.52.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1307696223.28682.21.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <62886fcb-651d-4529-98a1-58443dd83e9e@default> <4DF737EC0200007800046F1F@xxxxxxxxxxxxxxxxxxxx 1308040987.28682.52.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> From: Nikanth Karthikesan [mailto:nikanth@xxxxxxxxxx]
> Sent: Tuesday, June 14, 2011 2:43 AM
> To: Jan Beulich
> Cc: Dan Magenheimer; Jeremy Fitzhardinge; xen-devel@xxxxxxxxxxxxxxxxxxx; 
> Konrad Wilk
> Subject: RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen 
> Transcendent Memory only if
> Cleancache is enabled
> 
> On Tue, 2011-06-14 at 09:29 +0100, Jan Beulich wrote:
> > >>> On 13.06.11 at 16:58, Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 
> > >>> wrote:
> > >>  +obj-$(CONFIG_CLEAN_CACHE)      += tmem.o
> > >
> > > Hi Nikanth --
> > >
> > > Thanks for the suggested patch.  However, tmem.c works with both
> > > cleancache and frontswap... the shim in place only works with
> > > cleancache but there is a posted patch for it to work with
> > > frontswap as well.  So your patch would just need to be
> > > redone when frontswap is included soon.
> > >
> > > BUT... is there a way to do an inclusive-or operation
> > > in a Makefile?... something like this (though I know this
> > > exact syntax won't work)...
> > >
> > > obj-($CONFIG_CLEANCACHE||$CONFIG_FRONTSWAP)
> >
> > You can specify the same object more than once, i.e.
> >
> > obj-$(CONFIG_CLEAN_CACHE)   += tmem.o
> > obj-$(CONFIG_FRONTSWAP)     += tmem.o
> >
> 
> Cool!
> 
> So, can this patch be merged then? It would be easy to patch for
> frontswap, in the frontswap patchset.

I'm OK with the Makefile change, but the second part of your patch
that removes the #ifdef CONFIG_CLEANCACHE will just need to be
put in again when frontswap is added (as it will be possible that
CONFIG_FRONTSWAP=y but CONFIG_CLEANCACHE=n).

Is there a rush on this (i.e. is the compiler warning impeding
your work somehow)? As I said, it should all be cleaned up soon
so would prefer not to submit these piecemeal.

Thanks,
Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel