WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcendent

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcendent Memory only if Cleancache is enabled
From: Nikanth Karthikesan <nikanth@xxxxxxxxxx>
Date: Fri, 10 Jun 2011 14:27:03 +0530
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 10 Jun 2011 14:44:34 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1307696238; bh=cr3IFlyBnmHCr0S/CEXy8Xoc91M=; h=Subject:From:To:Cc:Content-Type:Date:Message-ID:Mime-Version: Content-Transfer-Encoding; b=WD0WeksdEFu1PkLC55F0qXMuuea1gEN+l1URt87A2RFtjeMBSCRzJVAiftojozYW8 JiYxjKsmDFOvqe0SzxKDQ==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:subject:from:to:cc:content-type:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=i28ZgFgxuBE0tcKUDEVFLPk87f92yZmQiwqjpnxkDi4=; b=mvUB+BFzge/U8exJomekBECPoyhOAumHDyL0isfmT1T7N45lR3hSxQs3UmwDEO79dN 02SLBnDTrKIRaXgPqgiQ==
Domainkey-signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=TXNHAy4+Ik1T1iZsHwtAHbrtPL1Xi4rEUJemtyqFHfpBl01hcDLoNN90xGeJFbvUkK 2zkdxf2JjU+QIXUSbgYA==
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
xen-tmem: Build cleancache shim to Xen Transcendent Memory only if Cleancache 
is enabled

Fix compilation warning

drivers/xen/tmem.c: In function ‘xen_tmem_init’:
drivers/xen/tmem.c:246: warning: unused variable ‘old_ops’
drivers/xen/tmem.c: At top level:
drivers/xen/tmem.c:234: warning: ‘tmem_cleancache_ops’ defined but not used

Signed-off-by: Nikanth Karthikesan <nikanth@xxxxxxxxxx>

---

Index: linux-2.6/drivers/xen/Makefile
===================================================================
--- linux-2.6.orig/drivers/xen/Makefile 2011-06-10 13:42:18.521140982 +0530
+++ linux-2.6/drivers/xen/Makefile      2011-06-10 13:44:50.110986353 +0530
@@ -1,6 +1,6 @@
 obj-y  += grant-table.o features.o events.o manage.o balloon.o
 obj-y  += xenbus/
-obj-y  += tmem.o
+obj-$(CONFIG_CLEAN_CACHE)      += tmem.o
 
 nostackp := $(call cc-option, -fno-stack-protector)
 CFLAGS_features.o                      := $(nostackp)
Index: linux-2.6/drivers/xen/tmem.c
===================================================================
--- linux-2.6.orig/drivers/xen/tmem.c   2011-06-10 12:19:14.522391890 +0530
+++ linux-2.6/drivers/xen/tmem.c        2011-06-10 13:45:42.500984200 +0530
@@ -247,7 +247,6 @@
 
        if (!xen_domain())
                return 0;
-#ifdef CONFIG_CLEANCACHE
        BUG_ON(sizeof(struct cleancache_filekey) != sizeof(struct tmem_oid));
        if (tmem_enabled && use_cleancache) {
                char *s = "";
@@ -257,7 +256,6 @@
                printk(KERN_INFO "cleancache enabled, RAM provided by "
                                 "Xen Transcendent Memory%s\n", s);
        }
-#endif
        return 0;
 }
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel