WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] patch fix-rx-packets-accounting

On Thu, Dec 16, 2010 at 11:49:04AM +0000, Paul Durrant wrote:
> No, I don't think so. The stats should be bumped on data ingress to the 
> shared ring. After all, if this were ethernet, you generally have no way of 
> knowing whether the packet you send ever makes it to its destination.
> 

OK. Thanks.

>   Paul
> 
> > -----Original Message-----
> > From: Ian Campbell
> > Sent: 16 December 2010 11:45
> > To: Paul Durrant
> > Cc: Konrad Rzeszutek Wilk; xen-devel@xxxxxxxxxxxxxxxxxxx
> > Subject: RE: [Xen-devel] [PATCH] patch fix-rx-packets-accounting
> > 
> > On Thu, 2010-12-16 at 11:37 +0000, Paul Durrant wrote:
> > > I think tx_packets and tx_bytes accounting is ok. Do you think
> > they are wrong?
> > 
> > I wonder if it might be more correct to only increment them if
> > status ==
> > NETIF_RSP_OK?
> > 
> > Ian.
> > 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel