WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] patch fix-rx-packets-accounting

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] patch fix-rx-packets-accounting
From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
Date: Thu, 16 Dec 2010 11:49:04 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Thu, 16 Dec 2010 03:50:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1292499886.32368.7420.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1292348283-5786-1-git-send-email-paul.durrant@xxxxxxxxxx> <1292348283-5786-2-git-send-email-paul.durrant@xxxxxxxxxx> <20101215154505.GD28984@xxxxxxxxxxxx> <291EDFCB1E9E224A99088639C47620228CF938AA71@xxxxxxxxxxxxxxxxxxxxxxxxx> <1292499886.32368.7420.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcudFqn2S7wiG15ART6+x/5Jm+nqCAAADwgg
Thread-topic: [Xen-devel] [PATCH] patch fix-rx-packets-accounting
No, I don't think so. The stats should be bumped on data ingress to the shared 
ring. After all, if this were ethernet, you generally have no way of knowing 
whether the packet you send ever makes it to its destination.

  Paul

> -----Original Message-----
> From: Ian Campbell
> Sent: 16 December 2010 11:45
> To: Paul Durrant
> Cc: Konrad Rzeszutek Wilk; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [Xen-devel] [PATCH] patch fix-rx-packets-accounting
> 
> On Thu, 2010-12-16 at 11:37 +0000, Paul Durrant wrote:
> > I think tx_packets and tx_bytes accounting is ok. Do you think
> they are wrong?
> 
> I wonder if it might be more correct to only increment them if
> status ==
> NETIF_RSP_OK?
> 
> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel