Re: [Xen-devel] libxl: build fix

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("Re: [Xen-devel] libxl: build fix"):
> On Monday 08 November 2010 17:38:18 Ian Jackson wrote:
> > Did you test this change ?
> 
> Sure. W/o that patch, compiling fails with
> "implicit declaration" on NetBSD.

No, I mean: did you execute the new code ?  Never mind.

> > Looking at the manpage I have here,
> 
> How does it differ to mine [1] ?
> [1] http://netbsd.gw.com/cgi-bin/man-cgi?basename+3+NetBSD-current

Look at the code and you will see that it assumes that basename does
not modify its argument.  I'm about to push a const-correctness fix
which will make this more obvious and cause your broken attempt at a
fix not to compile :-).

> > and the xl code, the version of 
> > basename() expected by the libxl cpuid code is the GNU one,
> > not the POSIX one, and they have different semantics.  I think we will have
> > to open code an implementation of basename.
> 
> Can you imagine to make Xen tools prefer POSIX over GNU in general, please?

I agree that the current code is a mistake.  The POSIX basename is
irritating and we shouldn't use it.  Simply open coding a search for a
'/' will be fine.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel