 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] libxl: build fix
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] libxl: build fix |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Mon, 8 Nov 2010 16:38:18 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Mon, 08 Nov 2010 08:39:19 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201011051608.47100.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <201011051608.47100.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Christoph Egger writes ("[Xen-devel] libxl: build fix"):
> Attached patch fixes libxl build.
> libgen.h is needed for basename().
Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Did you test this change ?
Looking at the manpage I have here, and the xl code, the version of
basename() expected by the libxl cpuid code is the GNU one, not the
POSIX one, and they have different semantics. I think we will have to
open code an implementation of basename.
I see that there is a lot of const-correctness misssing; if filename
had been declared const char* as it should your compiler would have
spotted the problem.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak, Konrad Rzeszutek Wilk |
|---|---|
| Next by Date: | Re: [Xen-devel] libxl: build fix, Christoph Egger |
| Previous by Thread: | [Xen-devel] libxl: build fix, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] libxl: build fix, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
