xen-devel
[Xen-devel] [PATCH 20/20] x86/ticketlock: rename ticketpair to head_tail
To: |
Peter Zijlstra <peterz@xxxxxxxxxxxxx> |
Subject: |
[Xen-devel] [PATCH 20/20] x86/ticketlock: rename ticketpair to head_tail |
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
Date: |
Wed, 3 Nov 2010 11:00:01 -0400 |
Cc: |
Nick Piggin <npiggin@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, Linux Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx> |
Delivery-date: |
Wed, 03 Nov 2010 08:18:05 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<cover.1288794124.git.jeremy.fitzhardinge@xxxxxxxxxx> |
In-reply-to: |
<cover.1288794124.git.jeremy.fitzhardinge@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<cover.1288794124.git.jeremy.fitzhardinge@xxxxxxxxxx> |
References: |
<cover.1288794124.git.jeremy.fitzhardinge@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Make it clearer what fields head_tail is actually overlapping with.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
---
arch/x86/include/asm/spinlock.h | 2 +-
arch/x86/include/asm/spinlock_types.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index a16b6e4..6850884 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -174,7 +174,7 @@ static __always_inline int
arch_spin_trylock(arch_spinlock_t *lock)
new.slock = tmp.slock + (1 << TICKET_SHIFT);
- ret = cmpxchg(&lock->ticketpair, tmp.slock, new.slock) == tmp.slock;
+ ret = cmpxchg(&lock->head_tail, tmp.slock, new.slock) == tmp.slock;
barrier(); /* just make nothing creeps before lock is
claimed */
return ret;
diff --git a/arch/x86/include/asm/spinlock_types.h
b/arch/x86/include/asm/spinlock_types.h
index 307ef0b..df031ec 100644
--- a/arch/x86/include/asm/spinlock_types.h
+++ b/arch/x86/include/asm/spinlock_types.h
@@ -24,7 +24,7 @@ typedef struct arch_spinlock {
struct {
__ticket_t waiting;
union {
- __ticketpair_t ticketpair;
+ __ticketpair_t head_tail;
struct __raw_tickets {
__ticket_t head, tail;
} tickets;
@@ -38,7 +38,7 @@ typedef struct arch_spinlock {
#else
typedef struct arch_spinlock {
union {
- __ticketpair_t ticketpair;
+ __ticketpair_t head_tail;
struct __raw_tickets {
__ticket_t head, tail;
} tickets;
--
1.7.2.3
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 08/20] x86/ticketlock: collapse a layer of functions, (continued)
- [Xen-devel] [PATCH 08/20] x86/ticketlock: collapse a layer of functions, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 01/20] x86/ticketlock: clean up types and accessors, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 11/20] x86/pvticketlock: use callee-save for lock_spinning, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 12/20] x86/pvticketlock: use callee-save for unlock_kick as well, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 17/20] x86/ticketlock: clarify barrier in arch_spin_lock, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 14/20] x86/ticketlock: loosen ordering restraints on unlock, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 16/20] x86/ticketlock: don't inline _spin_unlock when using paravirt spinlocks, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 09/20] xen/pvticketlock: Xen implementation for PV ticket locks, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 05/20] x86/ticketlock: make __ticket_spin_lock common, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 10/20] x86/pvticketlock: keep count of blocked cpus, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 20/20] x86/ticketlock: rename ticketpair to head_tail,
Jeremy Fitzhardinge <=
- [Xen-devel] [PATCH 07/20] x86/spinlocks: replace pv spinlocks with pv ticketlocks, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 15/20] x86/ticketlock: prevent compiler reordering into locked region, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 13/20] x86/pvticketlock: make sure unlock is seen by everyone before checking waiters, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 02/20] x86/ticketlock: convert spin loop to C, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 19/20] x86/ticketlocks: use overlapping read to eliminate mb(), Jeremy Fitzhardinge
- [Xen-devel] [PATCH 18/20] x86/ticketlock: remove .slock, Jeremy Fitzhardinge
- [Xen-devel] Re: [PATCH 00/20] x86: ticket lock rewrite and paravirtualization, H. Peter Anvin
|
|
|