WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH, RFC 3/4] qemu: use new (replacement) mmap-batch

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH, RFC 3/4] qemu: use new (replacement) mmap-batch ioctl
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2010 07:59:41 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 13 Jan 2010 00:00:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B4D893A02000078000299B5@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqUJRTS9GXwzpf4QSiEivd8NYWYHgAAUdjV
Thread-topic: [Xen-devel] [PATCH, RFC 3/4] qemu: use new (replacement) mmap-batch ioctl
User-agent: Microsoft-Entourage/12.23.0.091001
On 13/01/2010 07:50, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> This should be done by using the #ifdef arround the call to
>> xc_map_foreign_bulk, not by having a weak symbol compared to NULL.
> 
> While indeed I wasn't sure about how (or if at all) to put in
> backward compatibility, this seemed to be the consolidated place.
> 
> Using and #ifdef in the source file doesn't seem nice though, as it
> would tie a qemu built against older headers to using the old
> interface. But since I'm not sure about the compatibility needs in
> the first place, I will listen to whatever you say you deem
> appropriate.

Qemu is deemed part of the tollstack matched set, so compatibility with
older libxc is not an issue. The primary concern is to provide continued
compatibility with older dom0 kernels, which I believe you entirely handle
within libxc.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel