Re: [Xen-devel] [PATCH, RFC 3/4] qemu: use new (replacement) mmap-batch ioctl

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

I don't have any objections to this in principle, but:

> +#if __XEN_LATEST_INTERFACE_VERSION__ < 0x0003020a
> +void * __attribute__((__weak__))
> +xc_map_foreign_bulk(int xc_handle, uint32_t dom, int prot,
> +                    const xen_pfn_t *, int *err, unsigned int num);
> +#endif

This is pretty horrible.

This should be done by using the #ifdef arround the call to
xc_map_foreign_bulk, not by having a weak symbol compared to NULL.

You might consider whether the ability to use the old call is intended
to last forever.  Probably not, soi you should mark it deprecated.

Jan Beulich writes ("[Xen-devel] [PATCH, RFC 3/4] qemu: use new (replacement) 
mmap-batch ioctl"):
> -    phys_ram_base = xc_map_foreign_batch(xc_handle, domid,
> +    phys_ram_base = xc_map_foreign_pages(xc_handle, domid,
>                                           PROT_READ|PROT_WRITE,
>                                           page_array, nr_pages);

I'm not sure I understand this bug I haven't looked at it in any kind
of detail so it may be correct.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel