WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] hypercall_xlat_continuation()

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] hypercall_xlat_continuation()
From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
Date: Tue, 26 May 2009 11:43:48 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 26 May 2009 11:44:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C63D8BDE.BAC5%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corp
References: <C63D8BDE.BAC5%keir.fraser@xxxxxxxxxxxxx>
Reply-to: mukesh.rathor@xxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090320)


Keir Fraser wrote:
On 22/05/2009 22:58, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:

Ok. Even if I can't make it clearer, at least I'll add few lines of comments
explaining what's going on, after (and if) I figure it out.

Jan,

It seems assumption is made that a 64bit dom0 will not have a 32bit app making
hypercall?

BUG_ON(*reg != (unsigned int)*reg);  <====

You know that all the 'xlat' stuff in Xen is for 32-bit guests running on
64-bit hypervisor, right? 64-bit dom0 would never execute this logic.

Unless someone like me, in trying to make 32bit apps on 64bit dom0 work, causes it to take compat path if it's 32bit hcall. Yeah, I know whacky :)...

Thanks as always,
Mukesh

PS: If anyone is curious, if the call is 32bit hcall, in entry.S I make it jmp to compat/entry.S and do compat hcall. So far, other than this xlat stuff, seems ok! I set a register in dom0 to before hcall to indicate it's from a 32bit app.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel