WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] hypercall_xlat_continuation()

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] hypercall_xlat_continuation()
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Sat, 23 May 2009 23:44:19 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Sat, 23 May 2009 15:46:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C63D8BDE.BAC5%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <C63D8BDE.BAC5%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, 2009-05-23 at 06:17 -0400, Keir Fraser wrote:
> On 22/05/2009 22:58, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:
> 
> > Ok. Even if I can't make it clearer, at least I'll add few lines of comments
> > explaining what's going on, after (and if) I figure it out.
> > 
> > Jan,
> > 
> > It seems assumption is made that a 64bit dom0 will not have a 32bit app 
> > making
> > hypercall?
> > 
> > BUG_ON(*reg != (unsigned int)*reg);  <====
> 
> You know that all the 'xlat' stuff in Xen is for 32-bit guests running on
> 64-bit hypervisor, right? 64-bit dom0 would never execute this logic.

It's worth noting though that I don't believe a 32 bit dom0 toolstack on
a 64 bit kernel on a 64 bit hypervisor will work. In particular the
privcmd "make a hypercall" ioctl doesn't do any compat translation so 32
bit xend and friends can't make hypercalls that way and I think the
MMAPBATCH privcmd doesn't work either.

I'm sure there are other cases too (blktap user<->kernel ring layout
maybe?).

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel