| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] [VTD] Remove PCI device enumeration for dom0 in
|
To: |
Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH] [VTD] Remove PCI device enumeration for dom0 in Xen |
|
From: |
Yu Zhao <yu.zhao@xxxxxxxxxxxx> |
|
Date: |
Wed, 22 Oct 2008 23:39:02 +0800 |
|
Cc: |
"Kay, Allen M" <allen.m.kay@xxxxxxxxx>, "Zhao, Yu" <yu.zhao@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Han, Weidong" <weidong.han@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Delivery-date: |
Wed, 22 Oct 2008 08:39:37 -0700 |
|
Domainkey-signature: |
a=rsa-sha1; q=dns; c=nofws; s=default; d=uniscape.net; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=g6x6i4ZW7KkP42eFX6Q1h/eWTG86qXmLux6IHHB5rG4XeIBEuWHMxu9oEVqEi/Vbc4Fppkihand50X5tAfpxfow2Q4fvc0TEnRi3ksAWMgF1dZfCCia3fUjFTAVeQIWq; |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<18687.9027.201750.98978@xxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<18687.7900.317457.856048@xxxxxxxxxxxxxxxxxx> <C524DE97.28520%keir.fraser@xxxxxxxxxxxxx> <18687.9027.201750.98978@xxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.17 (X11/20080914) |
Espen Skoglund wrote:
[Keir Fraser]
On 22/10/08 13:38, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:
Xen 3.3 should continue to work with older dom0 kernels. However,
now that iommu is *disabled* by default, will this mean that it
would continue to work with older dom0 kernels so long as iommu is
not enabled on the Xen command line? This should be tested and
confirmed with this patch applied. If so, I would accept it.
Users of pci_lock_pdev() and pci_lock_domain_pdev() would not be
able to find the PCI device unless it has been registered by dom0.
Apart from the iommu code, the only user affected would be the MSI
code which looks up the PCI device before enabling MSIs on it. As
such, you would not be able to enable MSIs if you have an old dom0
kernel.
Is there any disadvantage to keeping this legacy code in Xen, apart
from it annoyingly sitting there?
You would get a list of PCI devices in Xen containing entries that are
not necessarily in use. Some of the entries might even be bogus.
Apart from some annoying extra code and additional entries in the
IOMMU page tables, I don't think there is much of a problem. There
could be some potential problems if Xen at a future stage decides to
do some in-hypervisor cleverness with all known PCI devices (a not
very likely scenario IMHO).
We would have bus number rebalance (hotplug, etc.) and PCI domain
support in the future, which may require hypervisor to keep consistent
device list with dom0 kernel. If we don't remove the code, we still have
to fix the list up.
Thanks,
Yu
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home