| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH] [VTD] Remove PCI device enumeration for dom0 in
|
To: |
"Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH] [VTD] Remove PCI device enumeration for dom0 in Xen |
|
From: |
"Han, Weidong" <weidong.han@xxxxxxxxx> |
|
Date: |
Wed, 22 Oct 2008 21:26:20 +0800 |
|
Cc: |
"Zhao, Yu" <yu.zhao@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Delivery-date: |
Wed, 22 Oct 2008 06:26:46 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<18687.10357.66955.73444@xxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<18687.7900.317457.856048@xxxxxxxxxxxxxxxxxx><C524DE97.28520%keir.fraser@xxxxxxxxxxxxx><0122C7C995D32147B66BF4F440D3016301E795BD@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <18687.10357.66955.73444@xxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
Ack0SQJc2favK6BlTT+kPSqZRW5dTgAAIa+A |
|
Thread-topic: |
[Xen-devel] [PATCH] [VTD] Remove PCI device enumeration for dom0 in Xen |
Espen Skoglund wrote:
> [Weidong Han]
>> Keir Fraser wrote:
>>> On 22/10/08 13:38, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx>
>>> wrote:
>>>> Users of pci_lock_pdev() and pci_lock_domain_pdev() would not be
>>>> able to find the PCI device unless it has been registered by dom0.
>>>> Apart from the iommu code, the only user affected would be the MSI
>>>> code which looks up the PCI device before enabling MSIs on it. As
>>>> such, you would not be able to enable MSIs if you have an old dom0
>>>> kernel.
>>>
>>> Is there any disadvantage to keeping this legacy code in Xen, apart
>>> from it annoyingly sitting there?
>>>
>
>> At present, I don't see any other disadvantage on functionality,
>> apart from it annoyingly sitting there and it allocates two pdev for
>> the same bdf.
>
> Allocates two pdevs? How? alloc_pdev() will not allocate a new pdev
> if the bdf already exists. It will just return the existing one.
>
You are right, it won't allocate twice for one bdf. I made a mistake -:(
Regards,
Weidong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home