[Xen-devel] Re: [PATCH] Share the IO_APIC_route_entry with iosapic

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

If you're making an arch-neutral io-apic header, you should move them. If
you just want a convenient stash for vt-d struct definitions, duplicate the
route_entry structure in a header under drivers/passthrough.

 -- Keir

On 7/10/08 08:49, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> The IO_APIC_reg_xx structures are not used in IPF side.
> Let me double check if we also need to move them.
> 
> Thanks,
> -- Dexuan
> 
> 
> -----Original Message-----
> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
> Sent: 2008年10月7日 15:34
> To: Cui, Dexuan; 'xen-devel@xxxxxxxxxxxxxxxxxxx'; Xu, Anthony
> Subject: Re: [PATCH] Share the IO_APIC_route_entry with iosapic
> 
> On 7/10/08 08:24, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:
> 
>> Hi Keir,
>> The iosapic continues to stay inside arch/ia64/; on the other hand, I think
>> the struct 'IO_APIC_route_entry' should be placed to a common place so that
>> IPF and x86 can share most of the common codes, like interrupt remapping.
>> To make the most use of the current x86 VT-d codes, I personally think
>> this movement of the definition of the struct IO_APIC_route_entry is
>> necessary
>> here.
>> Could you please comment this more?
> 
> Okay. Please move all arch-neutral definitions to xen/io_apic.h though --
> that will at a minimum be all IO_APIC_reg_xx structures.
> 
>  -- Keir
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel