WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] That xenstored console leak...

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] That xenstored console leak...
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Tue, 15 Jan 2008 08:59:49 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, John Levon <levon@xxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 15 Jan 2008 08:20:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3B276D5.1ACD6%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C3B276D5.1ACD6%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
Keir Fraser wrote:
> On 15/1/08 14:38, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:
>
>   
>>>> Anyway, seems like we need a simple working fix for 3.1 series, even if
>>>> there's larger surgery done.
>>>>         
>>> I checked your patch in for 3.1, which is probably sufficient there.
>>>       
>> The fix I was referring to was the one for the MAC-lossage issue.
>>     
>
> I'd consider taking Jim's patch to remove the path deletion, and swallow the
> (rather theoretical) xenstore leak across large numbers of device hotplugs.
>   

It's reality, not just theory :-/.  xm network-[attach|detach] does
leak.  block does not as nothing is written to /vm/uuid/device for block
devices.  Not sure about other devices, e.g. vtpm, security labels,
etc.  A quick grep through the sources reveals netif as the only dev
controller invoking _writeVm().

Perhaps we should look at handling network and block devices in a
similar fashion - eliminating the need to write any device info to this
path?

Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel