WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Thu, 26 Apr 2007 06:49:11 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 26 Apr 2007 03:47:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2560A59.65BF%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 04/26/2007 02:50:49 AM:

> On 26/4/07 04:36, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:
>
> > This fixes a compilation problem on 32 bit machines.
> >
> > Signed-off-by: Stefan Berger
>
> What's the issue?


It does not compile on 32bit because of those 4 lines. 64bit is fine.

>
> You're better off keeping the GUEST_HANDLE_64() and getting rid of the
> compat acm stuff. As far as I can see, all your interfaces are *currently*
> 32/64-bit invariant. So the compat stuff can safely be removed and then you
> don't need to continually keep it sync.


I was going to ask you about this. I am writing on a patch that puts all the ACM hypercall structures into a union. I am wondering what the compat stuff is for (xen/common/compat) and what the criterion is for needing this compat code.

   Stefan

>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel