This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit

To: Stefan Berger <stefanb@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 26 Apr 2007 07:50:49 +0100
Delivery-date: Wed, 25 Apr 2007 23:47:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1177558598.4833.1.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceHzzkkd5ALwfPCEduqvwAWy6hiGQ==
Thread-topic: [PATCH] [ACM] Comilation fix for 32 bit
User-agent: Microsoft-Entourage/
On 26/4/07 04:36, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:

> This fixes a compilation problem on 32 bit machines.
> Signed-off-by: Stefan Berger

What's the issue?

You're better off keeping the GUEST_HANDLE_64() and getting rid of the
compat acm stuff. As far as I can see, all your interfaces are *currently*
32/64-bit invariant. So the compat stuff can safely be removed and then you
don't need to continually keep it sync.

 -- Keir

Xen-devel mailing list