WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][RESEND] Control panel changes for IA64/VTI

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][RESEND] Control panel changes for IA64/VTI
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Mon, 24 Oct 2005 11:06:56 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Xen-IA64-Devel <Xen-IA64-Devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Oct 2005 10:04:10 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <571ACEFD467F7749BC50E0A98C17CDD802C068F2@pdsmsx403>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <571ACEFD467F7749BC50E0A98C17CDD802C068F2@pdsmsx403>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Oct 24, 2005 at 09:19:33AM +0800, Tian, Kevin wrote:

> >From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
> >
> >The patches look okay, although the Python bits aren't particularly
> >pretty.
> >
> >  -- Keir
> 
> Sorry for bad Python skill. ;-) So Dan, please help check in.

Actually executing your code would be a good start.

--- a/tools/python/xen/xend/image.py    Sat Oct 15 03:09:43 2005
+++ b/tools/python/xen/xend/image.py    Fri Oct 21 15:35:26 2005
@@ -58,6 +58,7 @@
     """
 
     ostype = None
+    page_kb = 4
 
 
     def __init__(self, vm, imageConfig, deviceConfig):
@@ -366,11 +367,13 @@
 
     def getDomainMemory(self, mem):
         """@see ImageHandler.getDomainMemory"""
+       if os.uname[4] == 'ia64':
+           page_kb = 16
         # for ioreq_t and xenstore
         static_pages = 2

This is going to fail with a TypeError exception, because os.uname is a
function.  You want os.uname()[4].

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel